Fix installation directory of YARP python bindings #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Unstable failures are due to #1764, I think we can safely ignore them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1762 .
The problem was two-fold:
YARP_OPTIONAL_DEPSwas used in place ofYARP_OPTIONAL_CMAKE_ARGSCMAKE_INSTALL_PYTHON3DIRis a PATH CACHE variable, so if we pass a relative path, it gets automatically expanded to the absolute path w.r.t. to the current work directory where cmake is invoked, while we want it to be relative w.r.t.${YCM_EP_INSTALL_DIR}(i.e. the variable that is passed asCMAKE_INSTALL_PREFIXto all projects)